Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Improve service account creation #4751

Merged

Conversation

sdimovv
Copy link
Contributor

@sdimovv sdimovv commented Feb 22, 2023

Details

  • Does this resolve an issue?
    N/A

Changes

New Features

  • Add ability to choose whether token should expire (and when) on service account creation
  • Set unusable password on service account creation

Breaking Changes

N/A

Additional

Somewhat related to #4727 as it would make creation of service accounts more intuitive.

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Base: 93.00% // Head: 92.99% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (93f624d) compared to base (1f7178c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4751      +/-   ##
==========================================
- Coverage   93.00%   92.99%   -0.01%     
==========================================
  Files         484      484              
  Lines       24455    24497      +42     
==========================================
+ Hits        22743    22778      +35     
- Misses       1712     1719       +7     
Flag Coverage Δ
e2e 53.47% <0.00%> (-0.12%) ⬇️
integration 26.73% <0.00%> (-0.04%) ⬇️
unit 89.70% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/core/api/users.py 93.42% <100.00%> (+0.11%) ⬆️
authentik/core/tests/test_users_api.py 100.00% <100.00%> (ø)
authentik/flows/api/stages.py 89.48% <0.00%> (-8.77%) ⬇️
authentik/stages/password/models.py 96.88% <0.00%> (-3.12%) ⬇️
authentik/events/monitored_tasks.py 96.20% <0.00%> (-0.95%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sdimovv
Copy link
Contributor Author

sdimovv commented Feb 22, 2023

Not sure why the ci-pylint fails. I haven't touched authentik/providers/oauth2/views/authorize.py. Also on my machine it shows no errors. I also tried make lint-fix - no changes.

@sdimovv
Copy link
Contributor Author

sdimovv commented Feb 22, 2023

Never mind, merging main fixed it

@BeryJu BeryJu merged commit c4e24c0 into goauthentik:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants