Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: fix authentik_system_tasks metric status label #6252

Merged
merged 1 commit into from Jul 13, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 13, 2023

Details

  • Does this resolve an issue?
    Resolves #

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner July 13, 2023 14:08
@BeryJu BeryJu requested review from rissson and removed request for a team July 13, 2023 14:08
@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit db070f7
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64b00574f949f30008fc2598

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.55 ⚠️

Comparison is base (b0bce60) 92.72% compared to head (db070f7) 91.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6252      +/-   ##
==========================================
- Coverage   92.72%   91.16%   -1.55%     
==========================================
  Files         551      551              
  Lines       26593    26593              
==========================================
- Hits        24655    24242     -413     
- Misses       1938     2351     +413     
Flag Coverage Δ
e2e 51.03% <ø> (-0.52%) ⬇️
integration ?
unit 89.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
authentik/events/monitored_tasks.py 95.46% <ø> (ø)

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BeryJu BeryJu merged commit 5ca6500 into main Jul 13, 2023
57 of 59 checks passed
@BeryJu BeryJu deleted the events/fix-authentik_system_tasks-metric branch July 13, 2023 14:24
kensternberg-authentik added a commit that referenced this pull request Jul 17, 2023
* main: (65 commits)
  enterprise: revise (#6272)
  web: bump API Client version (#6271)
  enterprise: initial enterprise (#5721)
  sources/ldap: check nsaccountlock for FreeIPA/389-ds (#6270)
  tests/e2e: improve assertCountEqual diff (#6261)
  web: bump @esbuild/darwin-arm64 from 0.18.12 to 0.18.13 in /web (#6266)
  website: bump clsx from 1.2.1 to 2.0.0 in /website (#6263)
  core: bump uvicorn from 0.22.0 to 0.23.0 (#6264)
  web: bump eslint from 8.44.0 to 8.45.0 in /web (#6268)
  web: bump @rollup/plugin-commonjs from 25.0.2 to 25.0.3 in /web (#6269)
  web: bump @esbuild/linux-arm64 from 0.18.12 to 0.18.13 in /web (#6267)
  website/blog: fixed bad link (#6257)
  website/docs: re-add goauthentik.io/user/can-change-* (#6251)
  core: bump twilio from 8.4.0 to 8.5.0 (#6254)
  core: bump sentry-sdk from 1.28.0 to 1.28.1 (#6255)
  website: bump postcss from 8.4.25 to 8.4.26 in /website (#6256)
  web: bump @sentry/browser from 7.58.0 to 7.58.1 in /web (#6248)
  web: bump @sentry/tracing from 7.57.0 to 7.58.1 in /web (#6249)
  events: fix authentik_system_tasks metric status label (#6252)
  web: bump @storybook/addon-links from 7.0.26 to 7.0.27 in /web (#6230)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant