Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/e2e: improve assertCountEqual diff #6261

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jul 16, 2023

Details

  • Does this resolve an issue?
    Resolves #

Changes

New Features

  • Adds feature which does x, y, and z.

Breaking Changes

  • Adds breaking change which causes <issue>.

Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner July 16, 2023 15:32
@BeryJu BeryJu requested review from rissson and removed request for a team July 16, 2023 15:32
@netlify
Copy link

netlify bot commented Jul 16, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit 743ddad
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/64b504925f58ea00085b567f
😎 Deploy Preview https://deploy-preview-6261--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.15 ⚠️

Comparison is base (7eef86a) 92.72% compared to head (b62b625) 92.57%.

❗ Current head b62b625 differs from pull request most recent head 743ddad. Consider uploading reports for the commit 743ddad to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6261      +/-   ##
==========================================
- Coverage   92.72%   92.57%   -0.15%     
==========================================
  Files         551      551              
  Lines       26593    26593              
==========================================
- Hits        24656    24615      -41     
- Misses       1937     1978      +41     
Flag Coverage Δ
e2e 50.74% <ø> (-0.82%) ⬇️
integration 26.37% <ø> (ø)
unit 89.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@netlify
Copy link

netlify bot commented Jul 17, 2023

Deploy Preview for authentik ready!

Name Link
🔨 Latest commit 743ddad
🔍 Latest deploy log https://app.netlify.com/sites/authentik/deploys/64b504927f71a40008818733
😎 Deploy Preview https://deploy-preview-6261--authentik.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-tests-improve-assertCountEqual-diff-1689585545-743ddad
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-tests-improve-assertCountEqual-diff-1689585545-743ddad-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-tests-improve-assertCountEqual-diff-1689585545-743ddad

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-tests-improve-assertCountEqual-diff-1689585545-743ddad-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit db4f615 into main Jul 17, 2023
60 checks passed
@BeryJu BeryJu deleted the tests/improve-assertCountEqual-diff branch July 17, 2023 09:47
kensternberg-authentik added a commit that referenced this pull request Jul 17, 2023
* main: (65 commits)
  enterprise: revise (#6272)
  web: bump API Client version (#6271)
  enterprise: initial enterprise (#5721)
  sources/ldap: check nsaccountlock for FreeIPA/389-ds (#6270)
  tests/e2e: improve assertCountEqual diff (#6261)
  web: bump @esbuild/darwin-arm64 from 0.18.12 to 0.18.13 in /web (#6266)
  website: bump clsx from 1.2.1 to 2.0.0 in /website (#6263)
  core: bump uvicorn from 0.22.0 to 0.23.0 (#6264)
  web: bump eslint from 8.44.0 to 8.45.0 in /web (#6268)
  web: bump @rollup/plugin-commonjs from 25.0.2 to 25.0.3 in /web (#6269)
  web: bump @esbuild/linux-arm64 from 0.18.12 to 0.18.13 in /web (#6267)
  website/blog: fixed bad link (#6257)
  website/docs: re-add goauthentik.io/user/can-change-* (#6251)
  core: bump twilio from 8.4.0 to 8.5.0 (#6254)
  core: bump sentry-sdk from 1.28.0 to 1.28.1 (#6255)
  website: bump postcss from 8.4.25 to 8.4.26 in /website (#6256)
  web: bump @sentry/browser from 7.58.0 to 7.58.1 in /web (#6248)
  web: bump @sentry/tracing from 7.57.0 to 7.58.1 in /web (#6249)
  events: fix authentik_system_tasks metric status label (#6252)
  web: bump @storybook/addon-links from 7.0.26 to 7.0.27 in /web (#6230)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant