Enable 'secure' option for pwgen #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the [pwgen manual](https://linux.die.net/man/1/pwgen, "pwgen manual"), the "-s"(secure) option instructs pwgen to generate completely random passwords, where as the default for pwgen is to generate more memorable passwords. Since, the passwords generated in this part of the installation process are to be "remembered" by the dot env file, I believe that users may benefit from the additional entropy provided by the "-s" option in pwgen.
|
✔️ Deploy Preview for authentik ready! 🔨 Explore the source changes: 08901f3 🔍 Inspect the deploy log: https://app.netlify.com/sites/authentik/deploys/62024c472f0b1f0007244e33 😎 Browse the preview: https://deploy-preview-2260--authentik.netlify.app |
|
TIL about this option, could you add it for the other pwgen examples too? |
Codecov Report
@@ Coverage Diff @@
## master #2260 +/- ##
==========================================
- Coverage 91.63% 90.55% -1.08%
==========================================
Files 447 447
Lines 19450 19450
==========================================
- Hits 17822 17611 -211
- Misses 1628 1839 +211
Continue to review full report at Codecov.
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Resolves #
Changes
New Features
Breaking Changes
Additional
As per the pwgen manual, the "-s"(secure) option instructs pwgen to generate completely random passwords, where as the default for pwgen is to generate more memorable passwords. Since the passwords generated in this part of the installation process are to be "remembered" by the dot env file, I believe that users may benefit from the additional entropy provided by the "-s" option in pwgen.
EDIT: Deleted unnecessary commas.