Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

customisable user settings #2397

Merged
merged 22 commits into from
Mar 2, 2022
Merged

customisable user settings #2397

merged 22 commits into from
Mar 2, 2022

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Feb 26, 2022

Signed-off-by: Jens Langhammer jens.langhammer@beryju.org

closes #2338
closes #2121

  • Remove update_self api endpoint
  • Add minimal flow executor in user interface
  • Add ability for prompts to use dynamic placeholders
    • Add tests
    • Add UI to edit expressions
    • Add docs for placeholders
  • Ensure backwards compat by still checking user attributes (remove later)
  • Add custom input types for inputs which use custom UI logic
    • ak-locale input type (to replace locale selection)

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
@BeryJu BeryJu self-assigned this Feb 26, 2022
@BeryJu BeryJu changed the title tenants: add user_settings flow, add basic flow and basic new executor customisable user settings Feb 26, 2022
@codecov
Copy link

codecov bot commented Feb 26, 2022

Codecov Report

Merging #2397 (bf791e6) into master (c57fbcf) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
+ Coverage   91.52%   91.60%   +0.08%     
==========================================
  Files         452      452              
  Lines       19630    19619      -11     
==========================================
+ Hits        17965    17970       +5     
+ Misses       1665     1649      -16     
Impacted Files Coverage Δ
authentik/core/api/users.py 91.79% <ø> (+2.08%) ⬆️
authentik/stages/prompt/api.py 100.00% <ø> (ø)
authentik/core/tests/test_users_api.py 100.00% <100.00%> (ø)
authentik/core/types.py 100.00% <100.00%> (ø)
authentik/flows/planner.py 100.00% <100.00%> (ø)
authentik/stages/prompt/models.py 100.00% <100.00%> (+8.52%) ⬆️
authentik/stages/prompt/stage.py 100.00% <100.00%> (+0.87%) ⬆️
authentik/stages/prompt/tests.py 100.00% <100.00%> (ø)
authentik/stages/user_write/stage.py 100.00% <100.00%> (ø)
authentik/tenants/api.py 96.08% <100.00%> (+0.08%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57fbcf...bf791e6. Read the comment docs.

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
@netlify
Copy link

netlify bot commented Feb 27, 2022

✔️ Deploy Preview for authentik ready!

🔨 Explore the source changes: 2e83364

🔍 Inspect the deploy log: https://app.netlify.com/sites/authentik/deploys/621b8858936a6700082fee9c

😎 Browse the preview: https://deploy-preview-2397--authentik.netlify.app

@netlify
Copy link

netlify bot commented Feb 27, 2022

✔️ Deploy Preview for authentik ready!

🔨 Explore the source changes: c5b4186

🔍 Inspect the deploy log: https://app.netlify.com/sites/authentik/deploys/621fcae125ff680007cf3a41

😎 Browse the preview: https://deploy-preview-2397--authentik.netlify.app

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
@sevmonster
Copy link
Contributor

This should also close #2121

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
…ocale attribute

Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
Signed-off-by: Jens Langhammer <jens.langhammer@beryju.org>
@BeryJu BeryJu merged commit 4f4f954 into master Mar 2, 2022
@BeryJu BeryJu deleted the flow-user-settings branch March 2, 2022 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to customize the user settings panel fields Ability to attach flows to the "Update details" page fields.
2 participants