Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outposts: use channel groups instead of saving channel names #7183

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 16, 2023

Details

Instead of managing channel name ourselves use channels' group feature to join all outpost channels into a per-outpost group that we can send messages to


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 16, 2023 13:46
@netlify
Copy link

netlify bot commented Oct 16, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 13fff2f
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/652d3fffa705920009085d2d

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (00b2a77) 92.67% compared to head (13fff2f) 92.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7183      +/-   ##
==========================================
- Coverage   92.67%   92.52%   -0.14%     
==========================================
  Files         568      568              
  Lines       28049    28044       -5     
==========================================
- Hits        25991    25946      -45     
- Misses       2058     2098      +40     
Flag Coverage Δ
e2e 50.43% <47.62%> (-0.75%) ⬇️
integration 26.44% <42.86%> (+0.11%) ⬆️
unit 89.57% <90.48%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/outposts/consumer.py 91.67% <100.00%> (ø)
authentik/outposts/models.py 86.59% <100.00%> (-2.03%) ⬇️
authentik/outposts/tasks.py 75.27% <100.00%> (ø)
authentik/outposts/tests/test_ws.py 100.00% <100.00%> (ø)
authentik/outposts/urls.py 100.00% <100.00%> (ø)
authentik/root/settings.py 88.00% <ø> (ø)
authentik/providers/proxy/tasks.py 72.23% <50.00%> (+5.56%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-outposts-use-groups-1697466191-13fff2f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-outposts-use-groups-1697466191-13fff2f-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-outposts-use-groups-1697466191-13fff2f

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-outposts-use-groups-1697466191-13fff2f-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 25d4905 into main Oct 16, 2023
61 of 62 checks passed
@BeryJu BeryJu deleted the outposts/use-groups branch October 16, 2023 15:01
kensternberg-authentik added a commit that referenced this pull request Oct 16, 2023
* main:
  web: the return of pseudolocalization (#7190)
  rbac: revisions (#7188)
  website: bump @babel/traverse from 7.21.4 to 7.23.2 in /website (#7187)
  web: bump API Client version (#7186)
  core: Initial RBAC (#6806)
  lifecycle: re-fix system migrations (#7185)
  outposts: use channel groups instead of saving channel names (#7183)
  sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous (#6862)
  website/docs: fix API OAuth token usage (#7159)
  web: bump rollup from 4.1.3 to 4.1.4 in /web (#7181)
  web: bump @formatjs/intl-listformat from 7.4.2 to 7.5.0 in /web (#7182)
  web: bump @rollup/plugin-replace from 5.0.3 to 5.0.4 in /web (#7177)
  web: bump the sentry group in /web with 2 updates (#7175)
  web: bump @rollup/plugin-commonjs from 25.0.5 to 25.0.7 in /web (#7178)
  web: bump yaml from 2.3.2 to 2.3.3 in /web (#7176)
  web: bump rollup from 4.0.2 to 4.1.3 in /web (#7179)
  web: bump the wdio group in /tests/wdio with 3 updates (#7180)
kensternberg-authentik added a commit that referenced this pull request Oct 17, 2023
* main: (23 commits)
  ci: test with postgres 16
  translate: Updates for file web/xliff/en.xlf in fr (#7189)
  web: bump the esbuild group in /web with 2 updates (#7195)
  web: bump the eslint group in /tests/wdio with 2 updates (#7192)
  core: bump ruff from 0.0.292 to 0.1.0 (#7194)
  web: bump the eslint group in /web with 2 updates (#7193)
  web: the return of pseudolocalization (#7190)
  rbac: revisions (#7188)
  website: bump @babel/traverse from 7.21.4 to 7.23.2 in /website (#7187)
  web: bump API Client version (#7186)
  core: Initial RBAC (#6806)
  lifecycle: re-fix system migrations (#7185)
  outposts: use channel groups instead of saving channel names (#7183)
  sources/ldap: made ldap_sync_single calls from ldap_sync_all asynchronous (#6862)
  website/docs: fix API OAuth token usage (#7159)
  web: bump rollup from 4.1.3 to 4.1.4 in /web (#7181)
  web: bump @formatjs/intl-listformat from 7.4.2 to 7.5.0 in /web (#7182)
  web: bump @rollup/plugin-replace from 5.0.3 to 5.0.4 in /web (#7177)
  web: bump the sentry group in /web with 2 updates (#7175)
  web: bump @rollup/plugin-commonjs from 25.0.5 to 25.0.7 in /web (#7178)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant