Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: fix oidc well-known parsing #7248

Merged
merged 2 commits into from Oct 20, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Oct 20, 2023

Details

Fix build


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner October 20, 2023 16:39
@netlify
Copy link

netlify bot commented Oct 20, 2023

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8204926
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6532b16c587e0d0007a73f42

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cbbb638) 52.59% compared to head (8204926) 92.62%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #7248       +/-   ##
===========================================
+ Coverage   52.59%   92.62%   +40.02%     
===========================================
  Files         587      587               
  Lines       28853    28852        -1     
===========================================
+ Hits        15176    26724    +11548     
+ Misses      13677     2128    -11549     
Flag Coverage Δ
e2e 50.98% <0.00%> (+<0.01%) ⬆️
integration 26.03% <0.00%> (+<0.01%) ⬆️
unit 89.63% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
authentik/sources/oauth/api/source.py 81.55% <100.00%> (+28.66%) ⬆️
authentik/sources/oauth/tasks.py 72.54% <100.00%> (+72.54%) ⬆️
authentik/sources/oauth/tests/test_views.py 100.00% <ø> (+100.00%) ⬆️

... and 391 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@github-actions
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-oauth-fix-well-known-parsing-1697821907-8204926
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-sources-oauth-fix-well-known-parsing-1697821907-8204926-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-oauth-fix-well-known-parsing-1697821907-8204926

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-sources-oauth-fix-well-known-parsing-1697821907-8204926-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 7e213f3 into main Oct 20, 2023
62 of 63 checks passed
@BeryJu BeryJu deleted the sources/oauth/fix-well-known-parsing branch October 20, 2023 18:37
kensternberg-authentik added a commit that referenced this pull request Oct 20, 2023
* main:
  sources/oauth: fix oidc well-known parsing (#7248)
  web/admin: improve user email button labels (#7233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant