Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web/flows: use aria-invalid attribute to better show invalid input fields #7661

Merged
merged 1 commit into from Nov 21, 2023

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Nov 21, 2023

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)
  • The translation files have been updated (make i18n-extract)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

…elds

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner November 21, 2023 12:20
Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit ca4fae3
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/655ca08c09b15800083c79ee
😎 Deploy Preview https://deploy-preview-7661--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (73751e5) 92.60% compared to head (ca4fae3) 92.58%.
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7661      +/-   ##
==========================================
- Coverage   92.60%   92.58%   -0.03%     
==========================================
  Files         587      587              
  Lines       29075    29075              
==========================================
- Hits        26924    26918       -6     
- Misses       2151     2157       +6     
Flag Coverage Δ
e2e 50.80% <ø> (-0.03%) ⬇️
integration 25.99% <ø> (ø)
unit 89.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu merged commit 2c6ac73 into main Nov 21, 2023
60 of 64 checks passed
@BeryJu BeryJu deleted the web/flows/improve-invalid-input-fields branch November 21, 2023 14:07
kensternberg-authentik added a commit that referenced this pull request Nov 21, 2023
* main:
  website/docs: add CVE-2023-48228 to release notes
  security: fix CVE-2023-48228 (#7666)
  website/docs: prepare 2023.10.4 release notes (#7641)
  web/admin: fix admins not able to delete MFA devices (#7660)
  web/flows: use aria-invalid attribute to better show invalid input fields (#7661)
  web: bump the esbuild group in /web with 2 updates (#7650)
  web: bump the eslint group in /tests/wdio with 2 updates (#7654)
  website: bump @types/react from 18.2.37 to 18.2.38 in /website (#7645)
  web: bump the sentry group in /web with 2 updates (#7647)
  web: bump the eslint group in /web with 2 updates (#7649)
  web: bump @types/codemirror from 5.60.13 to 5.60.14 in /web (#7651)
  web: bump typescript from 5.2.2 to 5.3.2 in /tests/wdio (#7656)
  web: bump the babel group in /web with 2 updates (#7648)
  core: bump django-filter from 23.3 to 23.4 (#7646)
  website: bump typescript from 5.2.2 to 5.3.2 in /website (#7644)
  web: bump @types/chart.js from 2.9.40 to 2.9.41 in /web (#7652)
  web: bump typescript from 5.2.2 to 5.3.2 in /web (#7653)
  web: bump the wdio group in /tests/wdio with 2 updates (#7655)
  web: bump wdio-wait-for from 3.0.8 to 3.0.9 in /tests/wdio (#7657)
kensternberg-authentik added a commit that referenced this pull request Nov 21, 2023
* main:
  website/docs: add CVE-2023-48228 to release notes
  security: fix CVE-2023-48228 (#7666)
  website/docs: prepare 2023.10.4 release notes (#7641)
  web/admin: fix admins not able to delete MFA devices (#7660)
  web/flows: use aria-invalid attribute to better show invalid input fields (#7661)
  web: bump the esbuild group in /web with 2 updates (#7650)
  web: bump the eslint group in /tests/wdio with 2 updates (#7654)
  website: bump @types/react from 18.2.37 to 18.2.38 in /website (#7645)
  web: bump the sentry group in /web with 2 updates (#7647)
  web: bump the eslint group in /web with 2 updates (#7649)
  web: bump @types/codemirror from 5.60.13 to 5.60.14 in /web (#7651)
  web: bump typescript from 5.2.2 to 5.3.2 in /tests/wdio (#7656)
  web: bump the babel group in /web with 2 updates (#7648)
  core: bump django-filter from 23.3 to 23.4 (#7646)
  website: bump typescript from 5.2.2 to 5.3.2 in /website (#7644)
  web: bump @types/chart.js from 2.9.40 to 2.9.41 in /web (#7652)
  web: bump typescript from 5.2.2 to 5.3.2 in /web (#7653)
  web: bump the wdio group in /tests/wdio with 2 updates (#7655)
  web: bump wdio-wait-for from 3.0.8 to 3.0.9 in /tests/wdio (#7657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant