Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenants: really ensure default tenant cannot be deleted #8875

Merged
merged 1 commit into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 0 additions & 5 deletions authentik/tenants/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ def save(self, *args, **kwargs):
raise IntegrityError("Cannot create schema named template")
super().save(*args, **kwargs)

def delete(self, *args, **kwargs):
if self.schema_name in ("public", "template"):
raise IntegrityError("Cannot delete schema public or template")
super().delete(*args, **kwargs)

@property
def serializer(self) -> Serializer:
from authentik.tenants.api.tenants import TenantSerializer
Expand Down
14 changes: 14 additions & 0 deletions authentik/tenants/signals.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
"""authentik tenants signals"""

from django.db import models
from django.db.models.signals import pre_delete
from django.dispatch import receiver
from django_tenants.utils import get_public_schema_name

from authentik.tenants.models import Tenant


@receiver(pre_delete, sender=Tenant)
def tenants_ensure_no_default_delete(sender, instance: Tenant, **kwargs):
if instance.schema_name == get_public_schema_name():
raise models.ProtectedError("Cannot delete schema public", instance)