Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lifecycle: migrate: ensure template schema exists before migrating #8952

Merged
merged 5 commits into from
Mar 25, 2024
Merged

lifecycle: migrate: ensure template schema exists before migrating #8952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee96736
lifecycle: migrate: ensure template schema exists before migrating
rissson Mar 18, 2024
1447b22
only run migration when needed
BeryJu Mar 19, 2024
c69941b
remove create schema from python migration
rissson Mar 21, 2024
aa2a691
Revert "remove create schema from python migration"
rissson Mar 21, 2024
10e7300
fix missing commit
BeryJu Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions lifecycle/migrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ def release_lock(cursor: Cursor):
"""Release database lock"""
if not LOCKED:
return
LOGGER.info("releasing database lock")
cursor.execute("SELECT pg_advisory_unlock(%s)", (ADV_LOCK_UID,))


Expand Down
12 changes: 12 additions & 0 deletions lifecycle/system_migrations/template_schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
from lifecycle.migrate import BaseMigration


class Migration(BaseMigration):
def needs_migration(self) -> bool:
self.cur.execute(
"SELECT schema_name FROM information_schema.schemata WHERE schema_name = 'template';"
)
return not bool(self.cur.rowcount)

def run(self):
self.cur.execute("CREATE SCHEMA IF NOT EXISTS template; COMMIT;")