Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix logic for token expiration #9426

Merged
merged 4 commits into from
Apr 25, 2024
Merged

core: fix logic for token expiration #9426

merged 4 commits into from
Apr 25, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 25, 2024

Signed-off-by: Jens Langhammer jens@goauthentik.io<!--
👋 Hi there! Welcome.

Please check the Contributing guidelines: https://goauthentik.io/developer-docs/#how-can-i-contribute
-->

Details

closes #9409


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested review from a team as code owners April 25, 2024 12:48
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 7a2ccfd
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/662a564b6f9a530008d42d8a

Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 7a2ccfd
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/662a564b7b51500008b2af33

@BeryJu
Copy link
Member Author

BeryJu commented Apr 25, 2024

/cherry-pick version-2024.4

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 92.41%. Comparing base (64f7fa6) to head (7a2ccfd).

Files Patch % Lines
authentik/core/api/tokens.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9426      +/-   ##
==========================================
- Coverage   92.42%   92.41%   -0.01%     
==========================================
  Files         668      668              
  Lines       32667    32666       -1     
==========================================
- Hits        30191    30189       -2     
- Misses       2476     2477       +1     
Flag Coverage Δ
e2e 50.66% <50.00%> (-0.02%) ⬇️
integration 26.02% <33.33%> (-0.01%) ⬇️
unit 89.69% <83.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-7a2ccfdb4ecad02551b8ffe3757259164f50ac83
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-7a2ccfdb4ecad02551b8ffe3757259164f50ac83-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-7a2ccfdb4ecad02551b8ffe3757259164f50ac83

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-7a2ccfdb4ecad02551b8ffe3757259164f50ac83-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 2997382 into main Apr 25, 2024
53 of 54 checks passed
@BeryJu BeryJu deleted the core/fix-app-password branch April 25, 2024 13:42
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 25, 2024
* core: fix logic for token expiration

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* bump default token expiration

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix frontend

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Apr 25, 2024
core: fix logic for token expiration (#9426)

* core: fix logic for token expiration



* bump default token expiration



* fix frontend



* fix



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Apr 30, 2024
* main:
  web: clean up some repetitive types (#9241)
  core: fix logic for token expiration (#9426)
  ci: fix ci pipeline (#9427)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9424)
  web: Add resolved and integrity fields back to package-lock.json (#9419)
  translate: Updates for file locale/en/LC_MESSAGES/django.po in ru (#9407)
  stages/identification: don't check source component (#9410)
  core: bump selenium from 4.19.0 to 4.20.0 (#9411)
  core: bump black from 24.4.0 to 24.4.1 (#9412)
  ci: bump golangci/golangci-lint-action from 4 to 5 (#9413)
  core: bump goauthentik.io/api/v3 from 3.2024023.2 to 3.2024040.1 (#9414)
  web: bump @sentry/browser from 7.112.1 to 7.112.2 in /web in the sentry group (#9416)
  sources/oauth: ensure all UI sources return a valid source (#9401)
  web: markdown: display markdown even when frontmatter is missing (#9404)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User cannot create app password
1 participant