Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sources/oauth: fix OAuth Client sending token request incorrectly #9474

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Apr 26, 2024

closes #9289

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

closes #9289

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner April 26, 2024 17:10
Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 85558a4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/662bdfea7c152100082e6ef9

Copy link

netlify bot commented Apr 26, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 85558a4
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/662bdfea596f59000847f5a9

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.40%. Comparing base (853239d) to head (85558a4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9474      +/-   ##
==========================================
- Coverage   92.41%   92.40%   -0.02%     
==========================================
  Files         668      668              
  Lines       32667    32667              
==========================================
- Hits        30190    30186       -4     
- Misses       2477     2481       +4     
Flag Coverage Δ
e2e 50.67% <100.00%> (+<0.01%) ⬆️
integration 26.02% <0.00%> (ø)
unit 89.69% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-85558a4065de54d2478758a76c7c02178cf6d70f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-85558a4065de54d2478758a76c7c02178cf6d70f-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-85558a4065de54d2478758a76c7c02178cf6d70f

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-85558a4065de54d2478758a76c7c02178cf6d70f-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu
Copy link
Member Author

BeryJu commented Apr 26, 2024

/cherry-pick version-2024.4

@BeryJu BeryJu merged commit a9c597b into main Apr 26, 2024
69 checks passed
@BeryJu BeryJu deleted the sources/oauth/fix-oauth-client-incorrect-request branch April 26, 2024 18:35
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 26, 2024
)

closes #9289

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request Apr 26, 2024
…erry-pick #9474) (#9475)

sources/oauth: fix OAuth Client sending token request incorrectly (#9474)

closes #9289

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
kensternberg-authentik added a commit that referenced this pull request Apr 30, 2024
* main: (36 commits)
  providers/rac: bump guacd to 1.5.5 (#9514)
  core: only prefetch related objects when required (#9476)
  website/integrations: move Fortimanager to Networking (#9505)
  website: bump react-tooltip from 5.26.3 to 5.26.4 in /website (#9494)
  web: bump the rollup group in /web with 3 updates (#9497)
  web: bump yaml from 2.4.1 to 2.4.2 in /web (#9499)
  core: bump goauthentik.io/api/v3 from 3.2024040.1 to 3.2024041.1 (#9503)
  core: bump pytest from 8.1.1 to 8.2.0 (#9501)
  website: bump react-dom from 18.3.0 to 18.3.1 in /website (#9495)
  website: bump react and @types/react in /website (#9496)
  web: bump react-dom from 18.3.0 to 18.3.1 in /web (#9498)
  core: bump sentry-sdk from 2.0.0 to 2.0.1 (#9502)
  web/flows: fix missing fallback for flow logo (#9487)
  events: ensure all models' __str__ can be called without any further lookups (#9480)
  core, web: update translations (#9482)
  flows: fix execute API endpoint (#9478)
  sources/oauth: fix OAuth Client sending token request incorrectly (#9474)
  web: bump API Client version (#9473)
  release: 2024.4.1
  website/docs: update release notes for 2024.4.1 again (#9471)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-basic-auth headers for external OAuth source
1 participant