Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: fix source_flow_manager saving user-source connection too early #9559

Merged
merged 2 commits into from
May 5, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 3, 2024

Details

REPLACE ME


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 3, 2024 15:11
Copy link

netlify bot commented May 3, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit e8c6134
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66350d27f5c34b00083a0eba

Copy link

netlify bot commented May 3, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit e8c6134
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66350d277beb82000838054e

@BeryJu
Copy link
Member Author

BeryJu commented May 3, 2024

/cherry-pick version-2024.4

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.47%. Comparing base (49cf10e) to head (e8c6134).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9559      +/-   ##
==========================================
+ Coverage   92.46%   92.47%   +0.01%     
==========================================
  Files         669      669              
  Lines       32751    32755       +4     
==========================================
+ Hits        30282    30290       +8     
+ Misses       2469     2465       -4     
Flag Coverage Δ
e2e 50.62% <0.00%> (-0.01%) ⬇️
integration 25.98% <0.00%> (-0.01%) ⬇️
unit 89.77% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 3, 2024 16:13
Copy link
Contributor

github-actions bot commented May 3, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e8c61344a84360cdb0f879018e94f7657586a20a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-e8c61344a84360cdb0f879018e94f7657586a20a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e8c61344a84360cdb0f879018e94f7657586a20a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-e8c61344a84360cdb0f879018e94f7657586a20a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 26daaeb into main May 5, 2024
68 checks passed
@BeryJu BeryJu deleted the core/source-flow-manager-don't-save-connection-early branch May 5, 2024 14:15
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 5, 2024
…#9559)

* core: fix source_flow_manager saving user-source connection too early

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* ci: fix branch name

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request May 5, 2024
… (cherry-pick #9559) (#9578)

core: fix source_flow_manager saving user-source connection too early (#9559)

* core: fix source_flow_manager saving user-source connection too early



* ci: fix branch name



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant