Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: fix SCIM ID incorrectly used as primary key (cherry-pick #9557) #9579

Merged
merged 1 commit into from
May 6, 2024

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked providers/scim: fix SCIM ID incorrectly used as primary key (#9557)

  • providers/scim: fix SCIM ID incorrectly used as primary key

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • fix unique together

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • add test

Signed-off-by: Jens Langhammer jens@goauthentik.io

  • add check for empty scim ID

Signed-off-by: Jens Langhammer jens@goauthentik.io


Signed-off-by: Jens Langhammer jens@goauthentik.io

* providers/scim: fix SCIM ID incorrectly used as primary key

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* fix unique together

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* add test

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* add check for empty scim ID

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner May 5, 2024 15:32
Copy link

netlify bot commented May 5, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 87b8238
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/6637a68b567cee0008c84918
😎 Deploy Preview https://deploy-preview-9579--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.50%. Comparing base (1d626f5) to head (87b8238).
Report is 1 commits behind head on version-2024.4.

Files Patch % Lines
authentik/providers/scim/clients/group.py 83.33% 1 Missing ⚠️
authentik/providers/scim/clients/user.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           version-2024.4    #9579      +/-   ##
==================================================
+ Coverage           92.47%   92.50%   +0.03%     
==================================================
  Files                 669      669              
  Lines               32844    32869      +25     
==================================================
+ Hits                30373    30407      +34     
+ Misses               2471     2462       -9     
Flag Coverage Δ
e2e 50.50% <20.00%> (+<0.01%) ⬆️
integration 25.93% <20.00%> (+0.01%) ⬆️
unit 89.81% <94.28%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented May 5, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-87b82387475fa2a32f48110bb57bb39f3d70179c
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-87b82387475fa2a32f48110bb57bb39f3d70179c-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-87b82387475fa2a32f48110bb57bb39f3d70179c

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-87b82387475fa2a32f48110bb57bb39f3d70179c-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu merged commit 35ba88a into version-2024.4 May 6, 2024
65 of 68 checks passed
@BeryJu BeryJu deleted the cherry-pick-9863cb-version-2024.4 branch May 6, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant