Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tenants: fix scheduled tasks not running on default tenant #9583

Merged
merged 3 commits into from
May 6, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented May 6, 2024

Details

closes #9574


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu requested a review from a team as a code owner May 6, 2024 00:23
@BeryJu
Copy link
Member Author

BeryJu commented May 6, 2024

/cherry-pick version-2024.4

Copy link

netlify bot commented May 6, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 0b464a8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66382bc6b659b900088ab8e8

Copy link

netlify bot commented May 6, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 0b464a8
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66382bc577ad130008dba3c3

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 92.51%. Comparing base (3c54e94) to head (0b464a8).
Report is 5 commits behind head on main.

Files Patch % Lines
authentik/tenants/scheduler.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9583      +/-   ##
==========================================
- Coverage   92.51%   92.51%   -0.01%     
==========================================
  Files         669      669              
  Lines       32873    32878       +5     
==========================================
+ Hits        30414    30416       +2     
- Misses       2459     2462       +3     
Flag Coverage Δ
e2e 50.49% <0.00%> (+<0.01%) ⬆️
integration 25.92% <0.00%> (-0.01%) ⬇️
unit 89.81% <40.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Copy link
Contributor

github-actions bot commented May 6, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-0b464a8e05d0e088f4ea9259e7c45f799c209df0
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-0b464a8e05d0e088f4ea9259e7c45f799c209df0-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-0b464a8e05d0e088f4ea9259e7c45f799c209df0

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-0b464a8e05d0e088f4ea9259e7c45f799c209df0-arm64

Afterwards, run the upgrade commands from the latest release notes.

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
@BeryJu BeryJu merged commit 06d1062 into main May 6, 2024
63 of 64 checks passed
@BeryJu BeryJu deleted the tenants/fix-scheduled-tasks branch May 6, 2024 01:16
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request May 6, 2024
* tenants: fix scheduled tasks not running on default tenant

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* add some extra time to keep system task around

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

* make sure we actually send it to all tenants

Signed-off-by: Jens Langhammer <jens@goauthentik.io>

---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
BeryJu added a commit that referenced this pull request May 6, 2024
#9583) (#9586)

tenants: fix scheduled tasks not running on default tenant (#9583)

* tenants: fix scheduled tasks not running on default tenant



* add some extra time to keep system task around



* make sure we actually send it to all tenants



---------

Signed-off-by: Jens Langhammer <jens@goauthentik.io>
Co-authored-by: Jens L <jens@goauthentik.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outpost Controller task (and thus respective pods) not starting when Authentik is started with helm chart
1 participant