Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website/developer-docs: add a baby Style Guide #9900
website/developer-docs: add a baby Style Guide #9900
Changes from all commits
3dd827b
b62daef
48192a3
ca51942
1a33476
7e8da54
53f0803
b5d50ee
a135432
462bd40
42ff322
e64d0e7
ef55c3f
5ad39d3
f72007a
c43f3f2
aa1320b
232e90d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use website/ instead of /website because website/ indicates a relative path within the repository, while /website suggests an absolute path from the root directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, this is a topic I have often discussed/debated. :-) I do actually intend it to be shown as an absolute path from the root dir. If they start at root, I want them to know what dir to look for from there.
True there are relative paths after/within
website
, but it's finding the top-level dir I want to focus on. Make sense?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't "set up" be "setup"? What I saw online seems to point towards the second option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"... the formatting command..." We have specific formatting commands:
make lint-fix
(for Django)make lint
(for Go and for other Python sources)cd web ; npm run prettier
(for the WebUI)cd website; npm run prettier
(for the web docs)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible I misunderstand the purpose of this document. For our product documentation (
./website/
), we have thenpm run prettier
command which will format your documents for you. (I'm surprised we don't run codespell or any other spell-check in there.). We have tools to enforce styling, and we should use more of them.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, about spell-check... I think we do run something, but whatever it is, is not as robust as what is in our final build pipeline! We will learn more soon, I hope. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You use the phrase
[docs template]
in that link consistently up until this point. Why change?