Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve MongoDB database to support use uri to support MongoDB Atlas. #227

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

1k-off
Copy link
Contributor

@1k-off 1k-off commented Feb 13, 2024

Added mongo atlas support.

}

func (db *Atlas) build() string {
return mongodumpCli + " " +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just extend the MongoDB to support Atlas?

Looks like we just need to add uri option can support this?

https://github.com/gobackup/gobackup/blob/main/database/mongodb.go#L60

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can of course. I updated code.

@huacnlee huacnlee changed the title feat: add support for atlas feat: Improve MongoDB database to support use uri to support MongoDB Atlas. Feb 29, 2024
@huacnlee huacnlee merged commit f50334a into gobackup:main Feb 29, 2024
1 check passed
@huacnlee
Copy link
Collaborator

Thank you.

@1k-off 1k-off deleted the feat/atlas branch March 2, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants