feat: webhook status urls #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ok urls for success and failure notifications
…k urls for success and failure notifications
…eat/webhook-status-urls
huacnlee
reviewed
Mar 4, 2024
| return successURL, failureURL, nil | ||
| } | ||
|
|
||
| return s.buildWebhookStatusURLs(successURL, failureURL) |
There was a problem hiding this comment.
This method is no impl?
And webhookStatusURLs no error return, why need error result?
huacnlee
reviewed
Mar 4, 2024
| url, err := s.webhookURL() | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| if len(notifyType) > 0 { | ||
| if len(successURL) > 0 && notifyType[0] == notifyTypeSuccess { |
There was a problem hiding this comment.
Why not just let notifyType is an int, this is an array but, just have one member?
There was a problem hiding this comment.
In the previous version there was no notifyType input at all, so I decided to use it as a variadic input parameter. This way we can ensure compatibility with the old code and provide or not provide this argument.
But yes, as you mentioned, it will be treated as an array then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #230