updated way in what skip items were calculated. if skip count was > 0… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, than it should be decreased bt one, since indexes in slice starting from 0
I won't actually call it a bug in package because it is unexported method and condition are already checked if user tries to assign negative numbers in Page and Limit method which fallbacks to default value. But still looking at the current method your solution is very good addition and I'll be merging the solution. Thanks for the test cases too. Cheers 🍻 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with skip number (
func getSkip()).If skipped value is grater than 0, it should be decreased by one, sine indexes in slice starting from 0