Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed regexp recompilation for each helper run #26

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

alexey-slivkin
Copy link
Contributor

@alexey-slivkin alexey-slivkin commented Apr 11, 2024

Performance boost

Description

Removed recompilation for each launch.

Issue: #27

Fixes # (issue)

Type of change

  • optimization

How Has This Been Tested?

Current tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Performance boost
Remove recompilation regexp
@alexey-slivkin alexey-slivkin marked this pull request as ready for review April 11, 2024 22:57
@alexey-slivkin alexey-slivkin changed the title Update helper.go Removed regexp recompilation for each helper run Apr 11, 2024
@gobeam gobeam merged commit 3769c2b into gobeam:master Apr 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants