Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Causes file access errors on Windows. A fix is provided in the comment. #19

Open
progmars opened this issue May 19, 2020 · 0 comments
Open

Comments

@progmars
Copy link

When running faceit on Windows, I got random handle and access errors in _extract_frames function.

To fix this, I added the following code:

video_clip.close() 

right after print('[extract-frames] frames already exist, skipping extraction: {}'.format(video_frames_dir))

and also at the very end of the _extract_frames function.

Yes, it's mostly a Windows issue because it is much more sensitive about accessing open files. On Linux, you generally can access the same file from many processes without any issues. Still, it's a good practice to close a file after you're done processing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant