Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bootsnap issues on Rails 5.2 #6

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Fixed bootsnap issues on Rails 5.2 #6

merged 1 commit into from
Apr 20, 2018

Conversation

xtrasimplicity
Copy link

@xtrasimplicity xtrasimplicity commented Apr 19, 2018 •
edited
Loading

Summary

Some test cases overwrote the Gemfile in order to remove other gems. I've added a 'remove gem from gemfile' step, to make this more robust.

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

This change is Reviewable

@xtrasimplicity xtrasimplicity mentioned this pull request Apr 19, 2018
Merged
6 tasks
@gobijan gobijan merged commit 32ba8db into gobijan:master Apr 20, 2018
@xtrasimplicity xtrasimplicity mentioned this pull request Apr 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gobijan gobijan gobijan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@xtrasimplicity @gobijan