Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pubsub] Fix entrypoint #97

Merged
merged 1 commit into from
Nov 12, 2021
Merged

[Pubsub] Fix entrypoint #97

merged 1 commit into from
Nov 12, 2021

Conversation

anovis
Copy link
Collaborator

@anovis anovis commented Nov 12, 2021

set entrypoint to goblet_entrypoint instead of app because of #88 (closes #95)

@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #97 (18b0107) into master (94f1944) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   88.99%   88.99%           
=======================================
  Files          25       25           
  Lines        1726     1726           
=======================================
  Hits         1536     1536           
  Misses        190      190           
Impacted Files Coverage Δ
goblet/decorators.py 87.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f1944...18b0107. Read the comment docs.

@anovis anovis merged commit aabbb74 into master Nov 12, 2021
@anovis anovis deleted the fix-pubsub-entrypoint branch November 12, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: main_handler() takes 1 positional argument but 2 were given with @app.topic('mytopic')
1 participant