Fix immediately dismissing popovers on iOS. #1893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goblindegook#57 I believe this bug happens because littlefoot handles both `touchend` and `click` event types with the same handler. On iOS and possibly other touch browsers, both events could be delivered each time the user taps the screen. The best practice is to call `event.preventDefault()` when handling the touch event to prevent the subsequent simulated mouse event from firing.
|
Thanks for this! Would you be able to cover this behaviour with a test to prevent regressions? |
|
I've added a test. I think the best I can do is test the touch event's |
|
Thanks for your fixes! I'll be making a release soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#57
I believe this bug happens because littlefoot handles both
touchendandclickevent types with the same handler. On iOS and possibly other touch browsers, both events could be delivered each time the user taps the screen. The best practice is to callevent.preventDefault()when handling the touch event to prevent the subsequent simulated mouse event from firing.