Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'LuaRocks' Dependency #58

Closed

Conversation

sage-etcher
Copy link

Runner doesn't include the LuaRocks alien tree if LuaRocks isn't listed as a dependency. This means that if a dependency like LuaRocks:MODULE_NAME needs to be accessible at build time, the build may fail.

This can be seen directly when trying to compile Awesome 4.3, which requires LuaRocks:lgi. As encountered in Recipes issue#128.

@hishamhm
Copy link
Member

hishamhm commented May 2, 2024

In an ideal world, rather than adding every language package manager as a dependency for Compile, Compile could derive that a Dependency of the kind Foo:bar means that package manager Foo is an implicit BuildDependency.

But since Awesome and by extension Lua are already in the default base system, just adding LuaRocks as a dependency here wouldn't be too problematic.

Without the LuaRocks dependency, Runner doesn't include the LuaRocks alien
tree. This causes dependencies like LuaRocks:MODULE_NAME to not be accessable
during the Recipe build step.
@sage-etcher
Copy link
Author

sage-etcher commented May 3, 2024

In an ideal world, rather than adding every language package manager as a dependency for Compile, Compile could derive that a Dependency of the kind Foo:bar means that package manager Foo is an implicit BuildDependency.

Assuming all goes accordingly, it doesnt look too difficult to implement in FindDependencies.c. I'll look into doing such =DD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants