Fixes generated models_test.go from importing old packr #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 10, 2019
There was a problem hiding this comment.
Found some fixes!
P.S. share your ideas, feedbacks or issues with us at https://github.com/fixmie/feedback (this message will be removed after the beta stage).
|
|
||
| import "fmt" | ||
|
|
||
| // go2 errors |
There was a problem hiding this comment.
existing comment doesn't match identifier "Wrapper"
Suggested change
| // go2 errors | |
| // Wrapper errors |
| Unwrap() error | ||
| } | ||
|
|
||
| // pkg/errors |
There was a problem hiding this comment.
existing comment doesn't match identifier "Causer"
Suggested change
| // pkg/errors | |
| // Causer ... |
| Cause() error | ||
| } | ||
|
|
||
| func Unwrap(err error) error { |
There was a problem hiding this comment.
exported identifier "Unwrap" should have comment
Suggested change
| func Unwrap(err error) error { | |
| // Unwrap ... | |
| func Unwrap(err error) error { |
| return err | ||
| } | ||
|
|
||
| var Cause = Unwrap |
There was a problem hiding this comment.
exported identifier "Cause" should have comment
Suggested change
| var Cause = Unwrap | |
| // Cause ... | |
| var Cause = Unwrap |
|
|
||
| var Cause = Unwrap | ||
|
|
||
| func Wrap(err error, msg string) error { |
There was a problem hiding this comment.
exported identifier "Wrap" should have comment
Suggested change
| func Wrap(err error, msg string) error { | |
| // Wrap ... | |
| func Wrap(err error, msg string) error { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.