-
Notifications
You must be signed in to change notification settings - Fork 22
Failed generate does not undo what did succeed. #17
Comments
How about making a copy of the modified files, modify the copy, and remove the original file on success?
That's not a problem, we're here to help! Start something from this idea if you like it, then we'll give you a hand to improve, if necessary. :) |
I'm interested in fixing this. Is it still relevant? @stanislas-m |
Sorry, I didn't see your message @orderbynull. It's still relevant. :) |
The problem persists! |
I take it no one fixed this issue? I'd be happy to help. |
Go for it.
…-----------
Mark Bates
On Mar 20, 2019, 11:24 AM -0400, James Hudson ***@***.***>, wrote:
I take it no one fixed this issue? I'd be happy to help.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Duplicate routes will occur even if generation succeeded after calling same command twice. Maybe it's better to check for identical lines of code while generating? |
This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This issue was closed because it has been stalled for 5 days with no activity. |
Steps to Reproduce the Problem
If buffalo fails midway through generating a resource it does not undo what it has done in
app.go
. This is a very minor issue and was easy to resolve by deleting the duplicated resources fromapp.go
. If I wasn't so new to go I'd be attempting to see if I could make a PR to fix this issue.buffalo g resource users name email bio:nulls.Text
with thebuffalo
executable file not found in $PATH. (execute buffalo without it being in your path folder).buffalo
to your path folderbuffalo g resource users name email bio:nulls.Text
againExpected Behavior
I think it would be nice if this was wrapped in some sort of transaction and would undo all steps if it fails midway through.
Info
The text was updated successfully, but these errors were encountered: