Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

preventing wrapping errors with point in error handler stack #137

Merged
merged 1 commit into from
Jan 15, 2017

Conversation

lumost
Copy link
Contributor

@lumost lumost commented Jan 15, 2017

This PR removes an extra errors.WithStack call which will wrap all errors handled by the defaultErrorHandler with the following stack trace. As this occurs for every defaultErrorHandler invocation in dev, and is formatted as if it was part of the primary stack trace it may be useful to remove this wrap.

github.com/gobuffalo/buffalo.defaultErrorHandler
/Users/lumost/src/github.com/gobuffalo/buffalo/errors.go:54
github.com/gobuffalo/buffalo.(*App).handlerToHandler.func1
/Users/lumost/src/github.com/gobuffalo/buffalo/handler.go:63
net/http.HandlerFunc.ServeHTTP
/usr/local/Cellar/go/1.7.4_1/libexec/src/net/http/server.go:1726
github.com/gorilla/mux.(*Router).ServeHTTP
/Users/lumost/src/github.com/gorilla/mux/mux.go:114
github.com/markbates/refresh/refresh/web.ErrorChecker.func1
/Users/lumost/src/github.com/markbates/refresh/refresh/web/web.go:23
net/http.HandlerFunc.ServeHTTP
/usr/local/Cellar/go/1.7.4_1/libexec/src/net/http/server.go:1726
github.com/gobuffalo/buffalo.(*App).ServeHTTP
/Users/lumost/src/github.com/gobuffalo/buffalo/app.go:44
net/http.serverHandler.ServeHTTP
/usr/local/Cellar/go/1.7.4_1/libexec/src/net/http/server.go:2202
net/http.(*conn).serve
/usr/local/Cellar/go/1.7.4_1/libexec/src/net/http/server.go:1579
runtime.goexit
/usr/local/Cellar/go/1.7.4_1/libexec/src/runtime/asm_amd64.s:2086

@markbates markbates merged commit ad7fa47 into gobuffalo:master Jan 15, 2017
@markbates
Copy link
Member

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants