Skip to content
This repository has been archived by the owner on Feb 24, 2024. It is now read-only.

Fix panic in buffalo info #1522

Merged
merged 1 commit into from Jan 4, 2019
Merged

Fix panic in buffalo info #1522

merged 1 commit into from Jan 4, 2019

Conversation

lukasschlueter
Copy link
Contributor

gobuffalo/meta@0d7e59d introduced an unexported field to gobuffalo/meta/app.go, causing a panic in buffalo info.

This commit will change the behaviour to ignore inaccessible fields.

@lukasschlueter lukasschlueter requested a review from a team January 4, 2019 19:24
@markbates
Copy link
Member

@lukasschlueter can you rebase against master so we can get this out in a 0.13 patch?

@lukasschlueter
Copy link
Contributor Author

v0.13.12 is not yet affected (change in meta didn't make it there yet).
If we're not planning to add changes (and especially the meta update) to the 0.13 versions anymore, I think merging into development is the cleaner option as it doesn't involve multiple commits (to master and dev).

But if you prefer, I'll rebase in a few minutes :-)

@markbates
Copy link
Member

markbates commented Jan 4, 2019 via email

@markbates markbates merged commit 7289afe into development Jan 4, 2019
@markbates markbates deleted the fix-info-panic branch January 4, 2019 20:52
@markbates markbates added this to the v0.14.0 milestone Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants