Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic in buffalo info #1522

Merged
merged 1 commit into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@lukasschlueter
Copy link
Member

lukasschlueter commented Jan 4, 2019

gobuffalo/meta@0d7e59d introduced an unexported field to gobuffalo/meta/app.go, causing a panic in buffalo info.

This commit will change the behaviour to ignore inaccessible fields.

@lukasschlueter lukasschlueter requested a review from gobuffalo/core-managers Jan 4, 2019

@markbates

This comment has been minimized.

Copy link
Member

markbates commented Jan 4, 2019

@lukasschlueter can you rebase against master so we can get this out in a 0.13 patch?

@lukasschlueter

This comment has been minimized.

Copy link
Member Author

lukasschlueter commented Jan 4, 2019

v0.13.12 is not yet affected (change in meta didn't make it there yet).
If we're not planning to add changes (and especially the meta update) to the 0.13 versions anymore, I think merging into development is the cleaner option as it doesn't involve multiple commits (to master and dev).

But if you prefer, I'll rebase in a few minutes :-)

@markbates

This comment has been minimized.

Copy link
Member

markbates commented Jan 4, 2019

@markbates markbates merged commit 7289afe into development Jan 4, 2019

3 checks passed

code-analysis/fixme The Fixmie analysis has finished
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@markbates markbates deleted the fix-info-panic branch Jan 4, 2019

@markbates markbates added this to the v0.14.0 milestone Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.