updated module dependencies, github action for testing, and etc. #139
Conversation
|
For some reason, currently, all the e2e tests run against sqlite. should be fixed. |
sio4
force-pushed
the
cleanup-for-buffalo-v1
branch
from
478cd23
to
1a91525
Compare
sio4
force-pushed
the
cleanup-for-buffalo-v1
branch
from
1a91525
to
cbe65ff
Compare
| @@ -25,7 +25,7 @@ jobs: | |||
| ports: | |||
| - 3307:3306 | |||
| # needed because the mysql container does not provide a healthcheck | |||
| options: --health-cmd "mysqladmin ping -h localhost" --health-interval 10s --health-timeout 5s --health-retries 5 | |||
| options: --health-cmd "mysqladmin ping -h localhost" --health-interval 5s --health-timeout 5s --health-retries 10 | |||
There was a problem hiding this comment.
short interval --> fast pass
| @@ -71,15 +71,15 @@ jobs: | |||
|
|
|||
| services: | |||
| postgres: | |||
| image: postgres:14 | |||
| image: postgres:10 | |||
There was a problem hiding this comment.
the minimum supported version of PostgreSQL is 10 currently.
| wget -qO- https://binaries.cockroachdb.com/cockroach-v2.1.0.linux-amd64.tgz | tar -xz | ||
| sudo cp -i cockroach-v2.1.0.linux-amd64/cockroach /usr/local/bin/ | ||
| cockroach start --insecure --background | ||
| wget -qO- https://binaries.cockroachdb.com/cockroach-v21.1.19.linux-amd64.tgz | tar -xz |
There was a problem hiding this comment.
The currentl minimum supported version of Cockroach DB is v21.1.
| cockroach start --insecure --background | ||
| wget -qO- https://binaries.cockroachdb.com/cockroach-v21.1.19.linux-amd64.tgz | tar -xz | ||
| mv cockroach-v21.1.19.linux-amd64/* . | ||
| ln -s `pwd`/cockroach /usr/local/bin/ |
There was a problem hiding this comment.
The recent version has two .so libraries so just make keep them in a single directory. However, the CLI should be in the PATH so just link it.
|
|
||
| A Common DSL for Migrating Databases | ||
|
|
||
| ## Create a Table | ||
|
|
||
| ## Supported Database Engines |
There was a problem hiding this comment.
This supported version and support policy are important. The basic policy should be "supporting the minimum supported version of each engine"
| @@ -2,20 +2,20 @@ mysql: | |||
| dialect: "mysql" | |||
| database: "pop_test" | |||
| host: {{ envOr "MYSQL_HOST" "127.0.0.1" }} | |||
| port: {{ envOr "MYSQL_PORT" "3306" }} | |||
| port: {{ envOr "MYSQL_PORT" "3307" }} | |||
There was a problem hiding this comment.
to prevent port conflict with locally installed versions. it will make it developers easy to test Fizz without having to worry about their existing local version.
| ports: | ||
| - "3306:3306" | ||
| - "3307:3306" | ||
| healthcheck: |
There was a problem hiding this comment.
to make sure the server is ready (replacing the sleep 10 workaround)
| then | ||
| verbose="-v" | ||
| fi | ||
| args=$@ |
|
|
||
| echo $@ | ||
| COMPOSE=docker-compose | ||
| which docker-compose || COMPOSE="docker compose" |
There was a problem hiding this comment.
the recent version is distributed as a form of plugin for docker
starting clean up for Buffalo core v1. (is also slightly related to #138)
68a6d4c - passed all
cbe65ff - failed on cockroach/e2e (the previous version is too old)
8360d1e - passed all