This repository has been archived by the owner on Jun 25, 2022. It is now read-only.
Ignore directories in disk resolver #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The disk resolver was the only one that returned directories as box files. This modification allows http redirections of index.html to work when working with the default disk resolver. A test case has been added to verify http's behavior when working with the disk resolver. Fix gobuffalo#162 Fix gobuffalo#211 Fix gobuffalo#235
markbates
approved these changes
Sep 30, 2019
|
Thanks! Released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The disk resolver was the only one that returned directories as box
files. This modification allows http redirections of index.html to
work when working with the default disk resolver.
A test case has been added to verify http's behavior when working with
the disk resolver.
Fix #162
Fix #211
Fix #235