This repository has been archived by the owner on Jun 25, 2022. It is now read-only.
gzip compress files #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated to pass unit tests and make as a command line option that defaults to off. Reduces the size of my frontend (Angular) app from 31M to 7.1M which results in my final executable being reduced from 41M to 18M. |
|
@jasonish sorry it took so long to get this merged in. I didn't realize the PR was here. I had to tweak it a little bit as it broke the public API, so I had to implement it in a way that didn't. It makes a huge difference. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you interested in adding compression? I took a stab at it, but am wondering if it should be a command line option?