Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix escape quote function #445

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fix escape quote function #445

merged 1 commit into from
Oct 15, 2019

Conversation

tatang26
Copy link
Contributor

Problem
Update and Delete are not working with tables name that have schema ("schema.table_name")

Behavior
Actual:

UPDATE "schema.table_name" SET...

Generate psql error

Expected:

UPDATE "schema"."table_name" SET...

DB used to test:
PostgreSQL 9.6

@tatang26 tatang26 requested a review from a team as a code owner October 15, 2019 12:32
@stanislas-m stanislas-m self-requested a review October 15, 2019 12:47
@stanislas-m stanislas-m merged commit 88a44ed into gobuffalo:development Oct 15, 2019
@stanislas-m
Copy link
Member

Thanks! 👍

@tatang26 tatang26 mentioned this pull request Oct 15, 2019
Closed
@tatang26 tatang26 deleted the bugfix-escape-quote-function branch October 15, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanislas-m stanislas-m stanislas-m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tatang26 @stanislas-m