Make SQLite URL parser aware of options #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, tests failing - I'll check what that's all about in an hour or so. |
aeneasr
force-pushed
the
sqlurl
branch
2 times, most recently
from
3d38bdf
to
571ed56
Compare
This patch improves the SQLite URL parser and adds the ability to specify conneciton options. Also uses `_fk=true` per default to allow propagation of foreign keys (disabled by default) Signed-off-by: aeneasr <aeneas@ory.sh>
|
Broken tests have been resolved, I made a small mistake in the URL generation. I also confirmed that outside libraries can now properly use and set parameters and connect to the database. So this is now good for review and merge! |
stanislas-m
approved these changes
Nov 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch improves the SQLite URL parser and adds the ability
to specify conneciton options.
Also uses
_fk=trueper default to allow propagation of foreignkeys (disabled by default)