Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom message for validation errors #1

Merged
merged 2 commits into from
Jul 18, 2018

Conversation

fdonzello
Copy link
Contributor

I think this is the first step to allow localization of error messages.
Actually, from now on, a developer can use the translator instance to translate the custom message error.

@fdonzello
Copy link
Contributor Author

fdonzello commented Apr 13, 2018

Any chances? :)

@fdonzello
Copy link
Contributor Author

hi @markbates, I'd like to contribute to the buffalo project but I need to know why no answers (I am not pretending you to merge or reject) have been posted since Mar 25.

At least a "I don't like your code" or "too busy now.." would have been appreciated...
But so far, I don't know if my efforts would lead to any improvements to the project.

@markbates
Copy link
Member

@fdonzello please don’t take offense. This PR just slipped through the cracks. I’ll take a look at it today. Over the last two months I’ve been traveling nearly every other week, so I’ve gotten way behind on some reviews. This is a lesser touched repo so it fell completely off the radar. I’ll get to it today.

@fdonzello
Copy link
Contributor Author

no offense at all ;)

Copy link
Member

@stanislas-m stanislas-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fdonzello Can you add an example about that feature in the Readme? :)

@fdonzello
Copy link
Contributor Author

sure, I'll provide asap

@markbates markbates merged commit 5759c93 into gobuffalo:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants