New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Godoc API is wrong about UpgradeHTTP #38

Closed

squarism opened this issue Mar 30, 2018 · 1 comment

squarism commented Mar 30, 2018

At the godoc main page:

http.HandleFunc("/", func(w http.ResponseWriter, r *http.Request) {
	  conn, err := ws.UpgradeHTTP(r, w, nil)
  })

Two variables are returned but looks like current source returns 4. It should be:
conn, _, _, err := ws.UpgradeHTTP(r, w, nil)

The text was updated successfully, but these errors were encountered:

Owner

gobwas commented Apr 14, 2018

Hi @squarism! Thanks for the catch. Fixed.

gobwas closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment