Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialer: move negotiated extension and copy extension parameters #158

Merged
merged 1 commit into from
Apr 10, 2023
Merged

dialer: move negotiated extension and copy extension parameters #158

merged 1 commit into from
Apr 10, 2023

Conversation

magicxyyz
Copy link
Contributor

Fixes #157

@magicxyyz
dialer: move negotiated extension and copy extension parameters
c43025e 
Fixes following issue:
Extensions in Handshake returned from (Dialer) Upgrade contain slices
pointing to memory in buffer already returned to pbufio.ReaderPool.
@cristaloleg cristaloleg merged commit 417ec07 into gobwas:master Apr 10, 2023
@cristaloleg
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handshake.Extentions pointing to a buffer already returned to pbufio.ReaderPool
2 participants
@magicxyyz @cristaloleg