Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github: run tests with Go 1.15 #173

Merged
merged 5 commits into from
Jun 1, 2023
Merged

.github: run tests with Go 1.15 #173

merged 5 commits into from
Jun 1, 2023

Conversation

alexandear
Copy link
Contributor

Because go.mod contains go 1.15 we need to ensure the library builds with Go 1.15 compiler. To avoid situations like #172.

@cristaloleg
Copy link
Collaborator

Not that fast https://github.com/gobwas/ws/actions/runs/5011502360/jobs/8982556717?pr=173#step:7:5

@cristaloleg
Copy link
Collaborator

Any plans to address that?

@cristaloleg
Copy link
Collaborator

Probably we need to skip build on macOS for 1.15.x completely 😬

@alexandear alexandear changed the title .github: build with Go 1.15 .github: run tests with Go 1.15 Jun 1, 2023
@cristaloleg cristaloleg merged commit 40c1550 into gobwas:master Jun 1, 2023
9 checks passed
@cristaloleg
Copy link
Collaborator

Thanks!

@alexandear alexandear deleted the github-build-go115 branch June 1, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @cristaloleg