Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ws,wsutil: use t.Fatal instead of panic #175

Merged
merged 1 commit into from
Oct 2, 2023
Merged

ws,wsutil: use t.Fatal instead of panic #175

merged 1 commit into from
Oct 2, 2023

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented May 19, 2023 •
edited

This PR replaces panic(err) with t.Fatal(err) where possible in wsutil tests. Also, replace t.Error(err); return with t.Fatal(err).

cristaloleg
cristaloleg reviewed May 19, 2023
View reviewed changes
wsutil/writer_test.go Outdated Show resolved Hide resolved
@alexandear alexandear changed the title wsutil: use t.Fatal instead of panic in tests test: use t.Fatal instead of panic May 22, 2023
@alexandear alexandear changed the title test: use t.Fatal instead of panic testing: use t.Fatal instead of panic May 22, 2023
@cristaloleg
Copy link
Collaborator

Oops, I somehow missed this PR. Can you rebase it on the latest master please?

@alexandear
Copy link
Contributor Author

@cristaloleg done

@cristaloleg cristaloleg changed the title testing: use t.Fatal instead of panic ws,wsutil: use t.Fatal instead of panic Oct 2, 2023
@cristaloleg cristaloleg merged commit a6c9785 into gobwas:master Oct 2, 2023
9 checks passed
@cristaloleg
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg Awaiting requested review from cristaloleg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @cristaloleg