Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float APIs - Part1 #664

Merged
merged 7 commits into from
Apr 21, 2020
Merged

Float APIs - Part1 #664

merged 7 commits into from
Apr 21, 2020

Conversation

st0012
Copy link
Member

@st0012 st0012 commented May 10, 2018

This PR is for continuing the work at #615 (thanks @SD10 for previous works)

It implements:

  • Float#abs Return positive number of the float. "Formally as the distance between 0 to the number of the float in 1-dimensional axis ..."

  • Float#ceil Returns the smallest number greater than or equal to the receiver

  • Float#floor Returns the largest number smaller than or equal to the receiver

  • Float#round Rounds float to a given precision in decimal digits (default 0 digits). Precision may be negative. Returns a floating-point number when n digits are more than zero.

  • Float#positive? Returns true if float number is larger than 0.0

  • Float#negative? Returns true if float number is less than 0.0

  • Float#zero? Returns true if float number is equal to 0.0

@st0012 st0012 added this to the version 0.1.10 milestone May 10, 2018
@st0012 st0012 self-assigned this May 10, 2018
@ghost ghost added the in progress label May 10, 2018
@codecov
Copy link

codecov bot commented May 10, 2018

Codecov Report

Merging #664 into master will decrease coverage by 0.10%.
The diff coverage is 64.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #664      +/-   ##
==========================================
- Coverage   81.11%   81.01%   -0.11%     
==========================================
  Files          54       54              
  Lines        7419     7468      +49     
==========================================
+ Hits         6018     6050      +32     
- Misses       1178     1186       +8     
- Partials      223      232       +9     
Impacted Files Coverage Δ
vm/float.go 76.66% <64.00%> (-4.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cfa98...7bac60e. Read the comment docs.

@st0012 st0012 changed the title Float APIs [WIP] Float APIs May 10, 2018
@st0012 st0012 modified the milestones: version 0.1.10, version 0.1.11 Jun 10, 2018
@st0012 st0012 mentioned this pull request Jun 10, 2018
15 tasks
@st0012 st0012 modified the milestones: version 0.1.11, version 0.1.12 Oct 13, 2019
@st0012 st0012 modified the milestones: version 0.1.12, version 0.1.13 Feb 16, 2020
@st0012 st0012 changed the title [WIP] Float APIs Float APIs - Part1 Apr 19, 2020
@st0012 st0012 merged commit 34840b4 into master Apr 21, 2020
@st0012 st0012 deleted the float-apis branch April 21, 2020 12:33
@SD10
Copy link
Member

SD10 commented Apr 22, 2020

🎉 Stay safe and healthy my friends

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants