Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Class.constants method. #686

Merged
merged 5 commits into from Jun 26, 2018
Merged

Add Class.constants method. #686

merged 5 commits into from Jun 26, 2018

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jun 17, 2018

No description provided.

@st0012 st0012 added this to the version 0.1.10 milestone Jun 17, 2018
@st0012 st0012 self-assigned this Jun 17, 2018
@st0012 st0012 requested a review from hachi8833 June 17, 2018 14:44
@ghost ghost added the in progress label Jun 17, 2018
@codecov
Copy link

codecov bot commented Jun 17, 2018

Codecov Report

Merging #686 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   81.99%   82.03%   +0.04%     
==========================================
  Files          57       57              
  Lines        7798     7805       +7     
==========================================
+ Hits         6394     6403       +9     
+ Misses       1133     1131       -2     
  Partials      271      271
Impacted Files Coverage Δ
vm/class.go 85.2% <100%> (+0.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df6e2e5...f15d21f. Read the comment docs.

@st0012
Copy link
Member Author

st0012 commented Jun 18, 2018

@hachi8833 can you help me review this?

Copy link
Member

@hachi8833 hachi8833 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interesting. Object.constants returns an array of any constants.

@st0012
Copy link
Member Author

st0012 commented Jun 21, 2018

I just found out I implemented it wrong. I should return the constants' name instead of their values

@hachi8833
Copy link
Member

I found that Object.constants looks unstable:

» Object.constants.first
#» ZeroDivisionError
» Object.constants.first
#» Decimal
» Object.constants.first
#» Module
» Object.constants.first
#» Module
» Object.constants.first
#» ArrayEnumerator

@st0012
Copy link
Member Author

st0012 commented Jun 24, 2018

@hachi8833 should be fixed now

@st0012 st0012 merged commit abcb9c0 into master Jun 26, 2018
@ghost ghost removed the in progress label Jun 26, 2018
@st0012 st0012 deleted the Support-constants-method branch June 26, 2018 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants