New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Class.constants method. #686
Conversation
Codecov Report
@@ Coverage Diff @@
## master #686 +/- ##
==========================================
+ Coverage 81.99% 82.03% +0.04%
==========================================
Files 57 57
Lines 7798 7805 +7
==========================================
+ Hits 6394 6403 +9
+ Misses 1133 1131 -2
Partials 271 271
Continue to review full report at Codecov.
|
@hachi8833 can you help me review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very interesting. Object.constants
returns an array of any constants.
I just found out I implemented it wrong. I should return the constants' name instead of their values |
I found that » Object.constants.first
#» ZeroDivisionError
» Object.constants.first
#» Decimal
» Object.constants.first
#» Module
» Object.constants.first
#» Module
» Object.constants.first
#» ArrayEnumerator |
@hachi8833 should be fixed now |
No description provided.