Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #809 #811

Merged
merged 3 commits into from Dec 12, 2019
Merged

Fix #809 #811

merged 3 commits into from Dec 12, 2019

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Dec 11, 2019

This PR fixes #809 and several other issues:

  1. goby_test.go's init setup didn't rebuild a clean binary before each run, so I fixed it.
  2. TestArgI test case wasn't working, fixed it as well.

@codecov
Copy link

codecov bot commented Dec 11, 2019

Codecov Report

Merging #811 into master will increase coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #811      +/-   ##
==========================================
+ Coverage   80.89%   80.92%   +0.02%     
==========================================
  Files          54       54              
  Lines        7403     7402       -1     
==========================================
+ Hits         5989     5990       +1     
+ Misses       1189     1188       -1     
+ Partials      225      224       -1
Impacted Files Coverage Δ
vm/thread.go 87.22% <ø> (+1.13%) ⬆️
vm/vm.go 82.53% <33.33%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf8e8f8...d4d6204. Read the comment docs.

Copy link
Member

@hachi8833 hachi8833 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick fix!

@st0012 st0012 merged commit c35b6f9 into master Dec 12, 2019
@st0012 st0012 deleted the fix-#809 branch December 12, 2019 03:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No output on error
2 participants