Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cause of this issue is that Goby pops the incorrect call frame when evaluating a
break
statement inside a built-in method's block.When evaluating a built-in method's call frame, Goby should pop it after the evaluation is finished. And we do this by calling
t.callFrameStack.pop()
directly, which makes sense in most cases.However, because the "break" instruction pops out 3 call frames every time (which is necessary, please read the comments inside
Break
instruction for more detail), it'd pop the built-in method's frame in advance. So when Goby finishes the built-in frame's evaluation later and tries to pop the frame from the stack, it actually pops the top frame, which later causes the nil pointer error.