Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support define_method and define_singleton_method #842

Merged
merged 8 commits into from
Apr 21, 2020
Merged

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Apr 18, 2020

This PR implements #839 but also contains other fixes & improvements that are required for the task:

  1. Fixes block compilation's argSet being nil issue.
  2. Fixes def statement working incorrectly inside instance_eval issue.
  3. Fixes singleton method definition gets overridden issue.
  4. Reformats Ripper test cases' expectations to improve readability.

@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #842 into master will increase coverage by 0.02%.
The diff coverage is 91.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #842      +/-   ##
==========================================
+ Coverage   81.01%   81.04%   +0.02%     
==========================================
  Files          54       54              
  Lines        7468     7500      +32     
==========================================
+ Hits         6050     6078      +28     
- Misses       1186     1188       +2     
- Partials      232      234       +2     
Impacted Files Coverage Δ
vm/class.go 86.36% <90.90%> (+0.29%) ⬆️
vm/instruction.go 89.50% <100.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34840b4...9483ea0. Read the comment docs.

@st0012 st0012 linked an issue Apr 18, 2020 that may be closed by this pull request
Copy link
Member

@64kramsystem 64kramsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't meaningfully review the code because I'm not familiar 😱

But at least I can point to some inconsistencies in spacing in the Ruby code between 9762f24 and ff6791f 😬 😂

@st0012
Copy link
Member Author

st0012 commented Apr 19, 2020

@saveriomiroddi ah it's always a pain to format goby code inside a go file 😞

@st0012 st0012 merged commit eb80f17 into master Apr 21, 2020
@st0012 st0012 deleted the support-#839 branch April 21, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support define_method define_singleton_method
2 participants