-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support define_method and define_singleton_method #842
Conversation
When using inside `instance_eval` block, the method should be defined on the instance's singleton class. (previously the instance's class)
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
==========================================
+ Coverage 81.01% 81.04% +0.02%
==========================================
Files 54 54
Lines 7468 7500 +32
==========================================
+ Hits 6050 6078 +28
- Misses 1186 1188 +2
- Partials 232 234 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@saveriomiroddi ah it's always a pain to format goby code inside a go file 😞 |
This PR implements #839 but also contains other fixes & improvements that are required for the task:
argSet
being nil issue.def
statement working incorrectly insideinstance_eval
issue.