-
Notifications
You must be signed in to change notification settings - Fork 137
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #332 from johankok/add-rollbar-as-error-handler
Added error handler for Rollbar
- Loading branch information
Showing
4 changed files
with
75 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
require 'hutch/logging' | ||
require 'rollbar' | ||
require 'hutch/error_handlers/base' | ||
|
||
module Hutch | ||
module ErrorHandlers | ||
class Rollbar < Base | ||
def handle(properties, payload, consumer, ex) | ||
message_id = properties.message_id | ||
prefix = "message(#{message_id || '-'}):" | ||
logger.error "#{prefix} Logging event to Rollbar" | ||
logger.error "#{prefix} #{ex.class} - #{ex.message}" | ||
|
||
::Rollbar.error(ex, | ||
payload: payload, | ||
consumer: consumer | ||
) | ||
end | ||
|
||
def handle_setup_exception(ex) | ||
logger.error "Logging setup exception to Rollbar" | ||
logger.error "#{ex.class} - #{ex.message}" | ||
|
||
::Rollbar.error(ex) | ||
end | ||
end | ||
end | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
require 'spec_helper' | ||
|
||
describe Hutch::ErrorHandlers::Rollbar do | ||
let(:error_handler) { Hutch::ErrorHandlers::Rollbar.new } | ||
|
||
describe '#handle' do | ||
let(:error) do | ||
begin | ||
raise "Stuff went wrong" | ||
rescue RuntimeError => err | ||
err | ||
end | ||
end | ||
|
||
it "logs the error to Rollbar" do | ||
message_id = "1" | ||
properties = OpenStruct.new(message_id: message_id) | ||
payload = "{}" | ||
consumer = double | ||
ex = error | ||
message = { | ||
payload: payload, | ||
consumer: consumer | ||
} | ||
expect(::Rollbar).to receive(:error).with(ex, message) | ||
error_handler.handle(properties, payload, consumer, ex) | ||
end | ||
end | ||
|
||
describe '#handle_setup_exception' do | ||
let(:error) do | ||
begin | ||
raise "Stuff went wrong" | ||
rescue RuntimeError => err | ||
err | ||
end | ||
end | ||
|
||
it "logs the error to Rollbar" do | ||
ex = error | ||
expect(::Rollbar).to receive(:error).with(ex) | ||
error_handler.handle_setup_exception(ex) | ||
end | ||
end | ||
end |