Improve specs related to Pseudo IBAN validation #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For IBANs it is specified which validation methods should be called during validation (see "validations called" example group). Do the same thing for Pseudo IBANs, and also describe expected country specific validations.
JoeSouthan
approved these changes
Oct 3, 2023
| describe "validations called" do | ||
| after { iban.valid? } | ||
|
|
||
| specify { expect(iban).to receive(:valid_pseudo_iban?).at_least(1) } |
There was a problem hiding this comment.
Not exactly a fan of testing internal methods but if this is existing and we find it valuable then its fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IBANs it is specified which validation methods should be called during validation (see "validations called" example group). Do the same thing for Pseudo IBANs, and also describe expected country specific validations.