This repository has been archived by the owner on Jan 8, 2024. It is now read-only.
Preprocess logs #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables us to add a new command that can do filtering of logs into a pre-processed form.
Previously we weren't deleting our item from the unbounds when we bound it in response to detail statements. This leads to a duplication of items that this commit tests for and fixes.
Allow preprocessing of a log file to create a logfile full of json serialized item entries that pgreplay can more easily consume. This should help during preprocessing while ensuring we do as little work as possible when running our benchmarks.
This will then match our log lines, ensuring Gomega equality will pass.
Ensure we can't doubly close our channel, while guaranteeing that we always close the channel at the earliest opportunity.
Without this, we'll leave many connections trailing during our benchmarking. That wouldn't be great, so this commit changes it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.