[feature] Add callbacks that trigger on transition failure #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwakefield
reviewed
Nov 4, 2019
There was a problem hiding this comment.
Seems like a good idea. My only concern is that it might not be immediately obvious that after_transition_failure would trigger for both GuardFailedError and TransitionFailedError
How would you feel about separating it into after_transition_failure & after_guard_failure ?
|
Hi @danwakefield -- sounds good. That's more obvious! I'll find some time to amend this PR tomorrow :) |
cedric-cordenier
force-pushed
the
transition-failure-callbacks
branch
from
1e1a160
to
656480f
Compare
|
@danwakefield I've updated my PR -- let me know if you have any further comments/questions |
danwakefield
approved these changes
Nov 5, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
We're big fans of statesman at work, but we've found that we'd really appreciate the ability to be able to define callbacks that are triggered when a transition fails. In this PR, I've added a new
after_transition_failurehook which extends the existing callback mechanism to add support for callbacks that are triggered if a transition fails.I'd really appreciate your thoughts on this,
Thanks,
Cedric