Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rspec-rails requirement from ~> 3.1 to ~> 6.0 #501

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

Tabby
Copy link
Contributor

@Tabby Tabby commented Mar 14, 2023

Recreation of the PR from dependabot due to CI changes. Also fixes errors and warnings from RSpec, either pre-existing or due to the dependency bump

Updates the requirements on rspec-rails to permit the latest version.

Changelog

Sourced from rspec-rails's changelog.

6.0.0

Full Changelog

Enhancements:

  • Support Rails 7
  • Template tweaks to remove instance variables from generated specs. (Takuma Ishikawa, #2599)
  • Generators now respects default path configuration option. (@​vivekmiyani, #2508)

Breaking Changes:

  • Drop support for Rails below 6.1
  • Drop support for Ruby below 2.5 (following supported versions of Rails 6.1)
  • Change the order of after_teardown from after to around in system specs to improve compatibility with extensions and Capybara. (Tim Diggins, #2596)

Deprecations:

  • Deprecates integration spec generator (rspec:integration) which was an alias of request spec generator (rspec:request) (Luka Lüdicke, #2374)

5.1.2 / 2022-04-24

Full Changelog

Bug Fixes:

  • Fix controller scaffold templates parameter name. (Taketo Takashima, #2591)
  • Include generator specs in the inferred list of specs. (Jason Karns, #2597)

5.1.1 / 2022-03-07

Full Changelog

Bug Fixes:

  • Properly handle global id serialised arguments in have_enqueued_mail. (Jon Rowe, #2578)

5.1.0 / 2022-01-26

Full Changelog

Enhancements:

  • Make the API request scaffold template more consistent and compatible with Rails 6.1. (Naoto Hamada, #2484)
  • Change the scaffold rails_helper.rb template to use require_relative. (Jon Dufresne, #2528)

5.0.3 / 2022-01-26

Full Changelog

... (truncated)

Commits
  • 0646044 v6.0.0
  • 7cd6f93 s/upload_backups_spec.rb/upload_backups_job_spec.rb/g
  • 8016684 Merge pull request #2587 from rspec/shanecav84/include-tagged-logging
  • 0b4d164 Fixed typo
  • 396c68f This updates Rubocop and uses the .rubocop_rspec_base.yml for consistency
  • efd4e6f Respect RSpec default_path for generators #2508
  • 40192d2 Remove legacy
  • 126da71 Remove version-specific checks for unsupported Rails/Ruby
  • 49f7dd5 Add integration generator deprecation to changelog
  • f604d5f Add only one test for integration generator deprecation
  • Additional commits viewable in compare view

Recreation of the PR from dependabot due to CI changes. Also fixes
errors and warnings from RSpec, either pre-existing or due to the
dependency bump
@Tabby Tabby merged commit b4ba5fd into master Mar 20, 2023
@Tabby Tabby deleted the rspec-rails-tw-6.0 branch March 20, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants