Fixed issue with transitions using STI #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tabby
approved these changes
Mar 16, 2023
|
Would love this to get merged, currently being bitten by this. Thanks @pedro-pedrosa |
Updating the `most_recent` column of all transitions of a model was not taking into account multiple state machines on the same model whose transitions implemented STI Add an AND clause to the query to filter by transition type if the transition class contains an inheritance column
Tabby
force-pushed
the
bugfix/active-record-adapter/sti
branch
from
46432e6
to
66629e3
Compare
dylan-hoefsloot
pushed a commit
to dylan-hoefsloot/statesman
that referenced
this pull request
Jan 11, 2024
Prior to 7.2.0 the code to unset the most_recent column of old transitions when a new transition was created relied on transitions_for_parent, which would build the correct query in the case that the transition class was using single table inheritance. However, after gocardless#399, the code no longer uses the parent association to create the query and the current custom query lacks this functionality that existed prior to 7.2.0. This PR addresses this issue by adding an AND clause to the query to filter by transition type if the transition class contains an inheritance column.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 7.2.0 the code to unset the
most_recentcolumn of old transitions when a new transition was created relied ontransitions_for_parent, which would build the correct query in the case that the transition class was using single table inheritance.However, after #399, the code no longer uses the parent association to create the query and the current custom query lacks this functionality that existed prior to 7.2.0.
This PR addresses this issue by adding an AND clause to the query to filter by transition type if the transition class contains an inheritance column.